Re: [tabled patch 2/4] fix the selection of chunk

Pete Zaitcev <[email protected]> Tue, 25 May 2010 21:25:13 -0600
Newsgroups org.kernel.vger.hail-devel
Message-ID <[email protected]>
On Tue, 25 May 2010 18:44:11 -0400
Jeff Garzik <[email protected]> wrote:

> On 05/21/2010 10:19 PM, Pete Zaitcev wrote:

> > +static int object_node_select(int *nx, struct db_obj_ent *obj)
> > +{
> > +	struct storage_node *stnode;
> > +				if (stnode->up)
> > +					return stnode;

> Did you compile or test this???

I suppose I deserved the tripple question mark for this. I tested it,
of course. The funny thing, everything is mapped below 4GB, way below
actually. As for warnings, I managed to miss them, because I started
running with -Wpointer-arith -Wsign-compare recently and that floods.
There's a lesson in it somewhere.

-- Pete