Re: [hail patch 1/1] fix hstor crashes
Jeff Garzik <[email protected]> Wed, 07 Jul 2010 20:44:57 -0400
| Newsgroups | org.kernel.vger.hail-devel |
|---|---|
| Message-ID | <[email protected]> |
On 07/07/2010 08:21 PM, Pete Zaitcev wrote: > This patch addresses two bugs: > > - No parameters to search worked (because character '=' was missing, > e.g. delim/ instead of delim=/), and also there were weird truncations > because prefix can easily be longer than 32 characters. > > - If prefix is empty, xmlNodeListGetString returns NULL instead of "", > thus segfault in strdup. This is not easy to accomplish with Boto, > but our own httpstor can do it. > > Signed-off-by: Pete Zaitcev<[email protected]> > > --- > lib/hstor.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > This patch was actually tested on httpstor, I've not switched to hstor > yet, but it seems to apply 100%. There's no sense in fixing httpstor, > I'm going to delete it from tabled soon. applied Check out 'libhail-merge' branch of tabled.git, it should have already fixed up the issues and the delete.