Re: [PATCH] don't expect inode name to be NUL-terminated (avoid read overrun)
Jeff Garzik <[email protected]> Tue, 14 Sep 2010 13:44:40 -0400
| Newsgroups | org.kernel.vger.hail-devel |
|---|---|
| Message-ID | <[email protected]> |
On 09/10/2010 08:55 AM, Jim Meyering wrote: > > * server/msg.c (msg_get): Copy only name_len bytes, then NUL-terminate, > rather than using snprintf to copy up to and including nonexistent NUL. > --- > > valgrind exposed this. The use of snprintf would have been > correct if the inode name buffer (following the struct raw_inode) > were NUL-terminated, but it is not. applied -- good catch out of curiosity, what is your patch base? We combined cld and chunkd into a single 'hail' pkg, and from the pathname, your patch was generated from the older cld pkg. We'd like to find the source and replace cld/chunkd with 'hail'. F12? F13? rawhide? Thanks, Jeff