Re: [PATCH tabled] server/server.c (net_write_port): Don't ignore write error.

On 09/23/2010 03:55 AM, Jim Meyering wrote:
> Better safe than sorry...
> Unreported write failures can be unpleasant.
> I fixed the one below so that a failure indication
> can propagate up the call tree.  You might also want to
> report the failure to stderr.
>
> I let my editor automatically update the copyright date
> and remove trailing spaces.
> If you'd rather separate those from the fix,
> let me know and I can adjust and resend.

Patch applied, thanks.

The typical preference is to receive whitespace and other cosmetic 
changes in a separate patch, thereby highlighting the functional changes.

But we're not so strict here that I would reject an otherwise useful 
patch...

Also FWIW, we're not very strict about reproducing the GCC-ish 
(GNU-ish?) style of "$FILENAME ($FUNCTION):" in each changelog -- though 
you're certainly welcome to continue, if that's your preference.

Given that "git show $COMMIT" will give you filename and per-diff-chunk 
function names, reproducing that in the git changelog entry seems 
somewhat redundant.  A simple, English-language summary of the change is 
fine.  Just a style tip, though, feel free to ignore!  :)

	Jeff