Re: [PATCH tabled] server/bucket.c: don't deref NULL upon failed malloc
Jeff Garzik <[email protected]> Thu, 23 Sep 2010 15:32:04 -0400
| Newsgroups | org.kernel.vger.hail-devel |
|---|---|
| Message-ID | <[email protected]> |
On 09/23/2010 10:03 AM, Pete Zaitcev wrote: > On Thu, 23 Sep 2010 12:53:06 +0200 > Jim Meyering<[email protected]> wrote: > >> I factored out the append_const definition to avoid >> having to wrap the long lines with the increased indentation. > >> p = s; >> >> +#define append_const(buf, c) \ >> + do { memcpy(buf, c, sizeof(c)-1); (buf) += sizeof(c)-1; } while (0) >> + >> tmpl = pfx_list; >> while (tmpl) { > > Dunno about Jeff, but I would definitely put an #undef to it > after the loop, just in case. Yeah, or after the function.