Re: [PATCH hail] lib/hstor.c: avoid an unconditional leak in append_qparam

Pete Zaitcev <[email protected]> Mon, 27 Sep 2010 18:24:14 -0600
Newsgroups org.kernel.vger.hail-devel
Message-ID <[email protected]>
On Mon, 27 Sep 2010 12:53:48 -0400
Jeff Garzik <[email protected]> wrote:

> > -	stmp = huri_field_escape(strdup(val), QUERY_ESCAPE_MASK);
> > +	v = strdup(val);
> > +	stmp = huri_field_escape(v, QUERY_ESCAPE_MASK);
> >   	str = g_string_append(str, stmp);
> >   	free(stmp);
> > +	free(v);
> 
> applied

I'm going to post a patch that undoes the damage. It's in testing.

-- Pete