Re: [PATCH v2] dracut: dmsquash-live: overlay module can be built-in the kernel

Frederick Grose <[email protected]> Tue, 2 Aug 2022 19:33:23 -0400
Newsgroups org.kernel.vger.initramfs
Message-ID <CAEcBt+X-gjoGiAc78anQmo1oGZHq09y6q6VVg4AEDJ5Xz+dz3g@mail.gmail.com>
How about this?
https://github.com/dracutdevs/dracut/pull/1886

On Tue, Aug 2, 2022 at 9:56 AM Federico Vaga <[email protected]> wrote:
>
> Hello,
>
> I've never got a feedback on this patch. Will it be integrated?
>
> Thanks
>
> On Wed, May 18, 2022 at 11:47:07AM +0200, Federico Vaga wrote:
> >The dmsquash-live module assumes that `overlay` is always a module.
> >Therefore, when `overlay` is built-in the kernel, this module will fail
> >to detect the presence of such a feature.
> >
> >This patch adds a fallback mechanism to check also `/proc/filesystem`.
> >This is also what happens with the dracut NSF module when loading the
> >kernel module `rpc_pipefs`.
> >
> >Signed-off-by: Federico Vaga <[email protected]>
> >---
> > v1 -> v2: do not use unnecessary sub-shell in the if statement
> >
> > modules.d/90dmsquash-live/dmsquash-live-root.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/modules.d/90dmsquash-live/dmsquash-live-root.sh b/modules.d/90dmsquash-live/dmsquash-live-root.sh
> >index fd8a858a..f68a979c 100755
> >--- a/modules.d/90dmsquash-live/dmsquash-live-root.sh
> >+++ b/modules.d/90dmsquash-live/dmsquash-live-root.sh
> >@@ -170,7 +170,7 @@ do_live_overlay() {
> >         fi
> >     fi
> >     if [ -n "$overlayfs" ]; then
> >-        if ! modprobe overlay; then
> >+        if ! { modprobe overlay || strstr "$(cat /proc/filesystems)" overlay; }; then
> >             if [ "$overlayfs" = required ]; then
> >                 die "OverlayFS is required but not available."
> >                 exit 1
> >--
> >2.27.0
> >
>
> --
> -------------------------------
> Federico Vaga - CERN BE-CEM-EDL