Re: [PATCH] io_uring: parenthesize io_ring_head_to_buf() expansion

On Thu, May 14, 2026 at 1:35 AM Yi Xie <[email protected]> wrote:
>
> Wrap the io_ring_head_to_buf() macro value in an extra pair of parentheses
> so it is safe when composed into larger expressions, and to satisfy
> scripts/checkpatch.pl.
>
> Signed-off-by: Yi Xie <[email protected]>
> ---
>  io_uring/kbuf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/io_uring/kbuf.c b/io_uring/kbuf.c
> index 63061aa1cab9..dd54e43e9ddf 100644
> --- a/io_uring/kbuf.c
> +++ b/io_uring/kbuf.c
> @@ -21,7 +21,7 @@
>  #define MAX_BIDS_PER_BGID (1 << 16)
>
>  /* Mapped buffer ring, return io_uring_buf from head */
> -#define io_ring_head_to_buf(br, head, mask)    &(br)->bufs[(head) & (mask)]
> +#define io_ring_head_to_buf(br, head, mask)    (&(br)->bufs[(head) & (mask)])

Is there a reason this can't just be an inline function?

Best,
Caleb

>
>  struct io_provide_buf {
>         struct file                     *file;
>