Re: [PATCH] io_uring: parenthesize io_ring_head_to_buf() expansion
Jens Axboe <[email protected]>
| Newsgroups | org.kernel.vger.io-uring |
|---|---|
| Message-ID | <[email protected]> |
On 5/14/26 8:58 AM, Gabriel Krisman Bertazi wrote: > Jens Axboe <[email protected]> writes: > >>>> /* Mapped buffer ring, return io_uring_buf from head */ >>>> -#define io_ring_head_to_buf(br, head, mask) &(br)->bufs[(head) & (mask)] >>>> +#define io_ring_head_to_buf(br, head, mask) (&(br)->bufs[(head) & (mask)]) >>> >>> Is there a reason this can't just be an inline function? >> >> And generally I don't like cleanups like this, but this one >> at least made sense to me. > > The annoying part, IMO, is that we/I look at every trivial fix > wondering if it really is just a parenthesis fix, or if it's the next > CopyFail/Fragnesia fix with an obfuscated commit message.. No kidding, trust no one these days, it's mostly all LLM and suspect :/ -- Jens Axboe