Re: [PATCH v3 01/11] io_uring: Use trace_call__##name() at guarded tracepoint call sites

Steven Rostedt <[email protected]>
Newsgroups org.kernel.vger.io-uring,org.kernel.vger.linux-trace-kernel
Message-ID <[email protected]>
On Fri, 15 May 2026 09:59:03 -0400
"Vineeth Pillai (Google)" <[email protected]> wrote:

> From: Vineeth Pillai <[email protected]>
> 

Hi Vineeth,

> Replace trace_foo() with the new trace_call__foo() at sites already
> guarded by trace_foo_enabled(), avoiding a redundant
> static_branch_unlikely() re-evaluation inside the tracepoint.
> trace_call__foo() calls the tracepoint callbacks directly without
> utilizing the static branch again.
> 

> Original v2 series:
> https://lore.kernel.org/linux-trace-kernel/[email protected]/
> 
> Parts of the original v2 series have already been merged in mainline.
> This patch is being reposted as a follow-up cleanup for the remaining
> unmerged pieces.

This part should go below the '---'. There's no reason to add it to the git
change log.

You should probably also state that these can now go in individually as all
the dependencies are upstream.

> 
> Suggested-by: Steven Rostedt <[email protected]>
> Suggested-by: Peter Zijlstra <[email protected]>
> Signed-off-by: Vineeth Pillai (Google) <[email protected]>
> Assisted-by: Claude:claude-sonnet-4-6
> ---

  <<here>>

Thanks,

-- Steve

>  io_uring/io_uring.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/io_uring/io_uring.h b/io_uring/io_uring.h
> index e612a66ee80e..1b657b714373 100644
> --- a/io_uring/io_uring.h
> +++ b/io_uring/io_uring.h
> @@ -312,7 +312,7 @@ static __always_inline bool io_fill_cqe_req(struct io_ring_ctx *ctx,
>  	}
>  
>  	if (trace_io_uring_complete_enabled())
> -		trace_io_uring_complete(req->ctx, req, cqe);
> +		trace_call__io_uring_complete(req->ctx, req, cqe);
>  	return true;
>  }
>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.