Re: (subset) [PATCHSET v2 0/6] io_uring related epoll cleanups

On 5/15/26 9:08 AM, Christian Brauner wrote:
> On Thu, 14 May 2026 08:07:16 -0600, Jens Axboe wrote:
>> One of the nastier things about epoll is how it allows nesting contexts
>> inside each other, leading to the necessity of loop detection and the
>> issues that have come with that.
>>
>> I don't believe there's any reason to support nesting on the io_uring
>> side, in fact IORING_OP_EPOLL_CTL is a historical mistake, imho. But
>> let's at least try and contain the damage and disallow nested contexts
>> from our side.
>>
>> [...]
> 
> @Jens, I added the epoll specific change to vfs-7.2.eventpoll. There
> were quite some merge conflicts now that I had to fix up. Please take a
> look and make sure it's sane. Otherwise I'm going to push this and will
> keep the branch stable.

I think your merge commit ended up messing it up, as you have

- static inline bool is_file_epoll(struct file *f)
 -int is_file_epoll(struct file *f)
++bool is_file_epoll(struct file *f)

which now makes it return a bool, and the header has it as an int
still.

-- 
Jens Axboe