Re: [PATCH] io_uring: propagate array_index_nospec opcode into req->opcode
Jens Axboe <[email protected]>
| Newsgroups | org.kernel.vger.io-uring,org.kernel.vger.bpf,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 5/15/26 8:58 AM, Michael Bommarito wrote:
> diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c
> index 4ed998d60c09c..7b257a03ef84c 100644
> --- a/io_uring/io_uring.c
> +++ b/io_uring/io_uring.c
> @@ -1739,6 +1739,7 @@ static int io_init_req(struct io_ring_ctx *ctx, struct io_kiocb *req,
> return io_init_fail_req(req, -EINVAL);
> }
> opcode = array_index_nospec(opcode, IORING_OP_LAST);
> + req->opcode = opcode;
>
> def = &io_issue_defs[opcode];
> if (def->is_128 && !(ctx->flags & IORING_SETUP_SQE128)) {
We could just kill 'opcode' while at it, and just use req->opcode for
this. I think that'd end up generating the same code, and avoid having
two versions of opcode.
--
Jens Axboe