Re: [PATCH v2] io_uring/io-wq: re-check IO_WQ_BIT_EXIT for each linked work item
Jens Axboe <[email protected]>
| Newsgroups | org.kernel.vger.io-uring,org.kernel.vger.linux-kernel,org.kernel.vger.stable |
|---|---|
| Message-ID | <177998255558.134892.12462292234696248083.b4-ty@b4> |
On Thu, 28 May 2026 01:22:03 +0800, Runyu Xiao wrote:
> commit 10dc95939817 ("io_uring/io-wq: check IO_WQ_BIT_EXIT inside work
> run loop") fixed the obvious case where io_worker_handle_work() took one
> exit-bit snapshot before draining pending work, but the fix stops one
> level too early.
>
> io_worker_handle_work() now re-checks IO_WQ_BIT_EXIT in its outer work
> run loop, yet it still snapshots that bit once before processing a
> whole dependent linked-work chain. If io_wq_exit_start() sets
> IO_WQ_BIT_EXIT after the first linked item has started, the remaining
> linked items can still reuse stale do_kill = false, skip
> IO_WQ_WORK_CANCEL, and continue running after exit has begun.
>
> [...]
Applied, thanks!
[1/1] io_uring/io-wq: re-check IO_WQ_BIT_EXIT for each linked work item
commit: 29bef9934b2521f787bb15dd1985d4c0d12ae02a
Best regards,
--
Jens Axboe