Re: [PATCH net-next v2 1/2] netdev: expose io_uring rx_page_order order via netlink
Jakub Kicinski <[email protected]>
| Newsgroups | org.kernel.vger.io-uring,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On Sat, 13 Jun 2026 16:09:03 +0200 Dragos Tatulea wrote: > On 13.06.26 11:53, Pavel Begunkov wrote: > > On 6/12/26 22:17, Dragos Tatulea wrote: > >> This adds observability for the io_uring zcrx rx-buf-len configuration. > > > > It might be nicer to look it up in the queue, e.g. rxq->mp_params, > > and make it a queue attribute instead of zcrx specific one. In either > > case, no objections. > > In io_pp_nl_fill() or in page_pool_nl_fill() as it was done in v1 for order? It's fine. We decided to make the "page size" a memory provider property, now we're going back to making it a queue level param? Like my RFC had that everyone hated so much? Sigh.