Re: [PATCH net-next v2 1/2] netdev: expose io_uring rx_page_order order via netlink

On 6/14/26 01:02, Jakub Kicinski wrote:
> On Sat, 13 Jun 2026 16:09:03 +0200 Dragos Tatulea wrote:
>> On 13.06.26 11:53, Pavel Begunkov wrote:
>>> On 6/12/26 22:17, Dragos Tatulea wrote:
>>>> This adds observability for the io_uring zcrx rx-buf-len configuration.
>>>
>>> It might be nicer to look it up in the queue, e.g. rxq->mp_params,
>>> and make it a queue attribute instead of zcrx specific one. In either
>>> case, no objections.
>>    
>> In io_pp_nl_fill() or in page_pool_nl_fill() as it was done in v1 for order?
> 
> It's fine. We decided to make the "page size" a memory provider
> property, now we're going back to making it a queue level param?
> Like my RFC had that everyone hated so much? Sigh.

TBH, I never cared much how nl would show it, so not opposing either
version. My idea is that even without plumbing in per-queue non-mp size
configuration, it'd be nice to have a common way to check it b/w
providers.

 From the semantics and observability perspective, zcrx is probably not
that interesting as the parameter is basically just a hint with no affect
on uapi, and I'd assume people would rather see the page pool size or even
the NIC's page size. But I guess it depends on what Dragos is really after
with this patch.

-- 
Pavel Begunkov