Re: [PATCH] io_uring, audit: don't log IORING_OP_RECV_ZC

Ricardo Robaina <[email protected]>
Newsgroups org.kernel.vger.io-uring,org.kernel.vger.linux-kernel
Message-ID <CAABTaaDURc908ahcf_E4bmdX-Lo1En42oZGvJUGS=o17ESN_dA@mail.gmail.com>
On Tue, Jun 16, 2026 at 11:44 AM Paul Moore <[email protected]> wrote:
>
> On Tue, Jun 16, 2026 at 8:36 AM Ricardo Robaina <[email protected]> wrote:
> >
> > IORING_OP_RECV_ZC is a read operation. Audit only tracks file/socket
> > creation ...
>
> That's not strictly correct, audit tracks more than just socket
> creation.  Connection events and connection-less writes are also of
> interest.
>
> > ... not subsequent reads. Set audit_skip to align with
> > audit-userspace uringop_table.h.
>
> While the logic above is correct, IORING_OP_RECV_ZC should be
> "audit_skip", the reasoning is backwards: the audit userspace io_uring
> table is dependent on the kernel, not the other way around (for what
> should be obvious reasons).
>
> Acked-by: Paul Moore <[email protected]>
>
> > Fixes: 11ed914bbf94 ("io_uring/zcrx: add io_recvzc request")
> > Suggested-by: Steve Grubb <[email protected]>
> > Signed-off-by: Ricardo Robaina <[email protected]>
> > ---
> >  io_uring/opdef.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/io_uring/opdef.c b/io_uring/opdef.c
> > index c3ef52b70811..fef134a21113 100644
> > --- a/io_uring/opdef.c
> > +++ b/io_uring/opdef.c
> > @@ -519,6 +519,7 @@ const struct io_issue_def io_issue_defs[] = {
> >  #endif
> >         },
> >         [IORING_OP_RECV_ZC] = {
> > +               .audit_skip             = 1,
> >                 .needs_file             = 1,
> >                 .unbound_nonreg_file    = 1,
> >                 .pollin                 = 1,
> > --
> > 2.53.0
>
> --
> paul-moore.com
>

Thanks for reviewing the patch and the clarification, Paul!

-Ricardo
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.