Re: [PATCH 2/2] io_uring/uring_cmd: fix uring_cmd.c comments

On Thu, Jul 2, 2026 at 1:43 AM Yang Xiuwei <[email protected]> wrote:
>
> Fix "concelable" -> "cancelable" in the comment above
> io_uring_cmd_mark_cancelable(), and fix the memory ordering comment
> in __io_uring_cmd_done() to reference io_do_iopoll() and
> ->iopoll_completed.
>
> Signed-off-by: Yang Xiuwei <[email protected]>
> ---
>  io_uring/uring_cmd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/io_uring/uring_cmd.c b/io_uring/uring_cmd.c
> index fe32311b2e51..8313600583b5 100644
> --- a/io_uring/uring_cmd.c
> +++ b/io_uring/uring_cmd.c
> @@ -90,7 +90,7 @@ static void io_uring_cmd_del_cancelable(struct io_uring_cmd *cmd,
>  }
>
>  /*
> - * Mark this command as concelable, then io_uring_try_cancel_uring_cmd()
> + * Mark this command as cancelable, then io_uring_try_cancel_uring_cmd()
>   * will try to cancel this issued command by sending ->uring_cmd() with
>   * issue_flags of IO_URING_F_CANCEL.
>   *
> @@ -168,7 +168,7 @@ void __io_uring_cmd_done(struct io_uring_cmd *ioucmd, s32 ret, u64 res2,
>         }
>         io_req_uring_cleanup(req, issue_flags);
>         if (req->flags & REQ_F_IOPOLL) {
> -               /* order with io_iopoll_req_issued() checking ->iopoll_complete */
> +               /* order with io_do_iopoll() checking ->iopoll_completed */

Looks like the comment in io_complete_rw_iopoll() also refers to a
(different) incorrect function

Best,
Caleb

>                 smp_store_release(&req->iopoll_completed, 1);
>         } else if (issue_flags & IO_URING_F_COMPLETE_DEFER) {
>                 if (WARN_ON_ONCE(issue_flags & IO_URING_F_UNLOCKED))
> --
> 2.25.1
>
>