Re: [PATCH 1/2] io_uring/uring_cmd: copy SQE before issue_blocking punt

On 7/2/26 12:06 PM, Caleb Sander Mateos wrote:
> On Thu, Jul 2, 2026 at 10:43 AM Caleb Sander Mateos
> <[email protected]> wrote:
>>
>> On Thu, Jul 2, 2026 at 1:41 AM Yang Xiuwei <[email protected]> wrote:
>>>
>>> io_uring_cmd_issue_blocking() punts to io-wq without copying the SQE
>>> off the submission queue, unlike the -EAGAIN and fallback paths. Copy
>>> the SQE into async data before queuing the work.
>>
>> Add a Fixes tag?
>> Fixes: ecf47d452ced ("io_uring/uring_cmd: implement ->sqe_copy() to
>> avoid unnecessary copies")
> 
> Actually I'm not convinced this is an issue at all. Since commit
> 212ec34e4e72 ("block: only read from sqe on initial invocation of
> blkdev_uring_cmd()"), blkdev_uring_cmd() only accesses the SQE on the
> initial issue. Even if the uring_cmd is re-issued asynchronously, it
> doesn't rely on the SQE having been preserved.

Yeah I agree, after taking a closer look. I'll kill this patch. I do
like your followup cleaning up the punting, will queue that for 7.3.

-- 
Jens Axboe