Re: [PATCH] io_uring/rw: fix missing ERESTARTSYS conversion in read paths
Jens Axboe <[email protected]> Tue, 21 Jul 2026 10:32:40 -0600
| Newsgroups | org.kernel.vger.io-uring |
|---|---|
| Message-ID | <[email protected]> |
On 7/20/26 5:41 AM, Yitang Yang wrote: > Both read and write may receive internal restart error codes from > the filesystem layer and should be converted to -EINTR. However, > when multishot read support was added, the error code normalization > was lost for both io_read() and io_read_mshot(). > > Extract the conversion into io_fixup_restart_res() and apply it > in all three locations: io_rw_done(), io_read(), and io_read_mshot(). How was this found? Reason I ask is that I wonder if this is even necessary in the first place. If you found this because of an issue you ran into, then that answers that question clearly (yes we need it). But if this some LLM find, then that's an entirely different story. -- Jens Axboe