Re: [PATCH v3 1/1] pipe: only enable the extra wake_up(rd_wait) for edge-triggered consumers
Mateusz Guzik <[email protected]> Thu, 30 Jul 2026 22:01:56 +0200
| Newsgroups | org.kernel.vger.io-uring,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <CAGudoHE=GjMRKGbip8nRUm34VUud_YSqGZJrfr+Vz6Qu22Mdaw@mail.gmail.com> |
On Thu, Jul 30, 2026 at 4:38=E2=80=AFPM Oleg Nesterov <[email protected]> wro= te: > What exactly do you think the comment should say? I agree with anything i= n > advance. I thought that "edge-triggered" provides enough info, but I woul= d > be happy to improve the docs. > how about: There is userspace depending on the extra wake up, see commit 3a34b13a88caeb28 ("pipe: make pipe writes always wake up readers") for details. or whatever else which refers to the commit, no need for anything fancy. the current commentary is definitely lame. > And the helper's name? pipe_enable_poll_et() ? > perhaps pipe_enable_epoll_semantics()?