[PATCH] iommu/vsi: Use list_for_each_entry()
Dan Carpenter <[email protected]>
| Newsgroups | org.kernel.vger.kernel-janitors,dev.linux.lists.iommu,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Smatch complains about the NULL check on "iommu" because list_entry() can't be NULL. Clean up this code by using list_for_each_entry(). Signed-off-by: Dan Carpenter <[email protected]> --- Untested, but it compiled on the first try (no typos!) drivers/iommu/vsi-iommu.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/iommu/vsi-iommu.c b/drivers/iommu/vsi-iommu.c index 5d0721bd2c7a..9954ed414526 100644 --- a/drivers/iommu/vsi-iommu.c +++ b/drivers/iommu/vsi-iommu.c @@ -366,15 +366,9 @@ static int vsi_iommu_map_iova(struct vsi_iommu_domain *vsi_domain, u32 *pte_addr static void vsi_iommu_flush_tlb(struct iommu_domain *domain) { struct vsi_iommu_domain *vsi_domain = to_vsi_domain(domain); - struct list_head *pos; - - list_for_each(pos, &vsi_domain->iommus) { - struct vsi_iommu *iommu; - - iommu = list_entry(pos, struct vsi_iommu, node); - if (!iommu) - continue; + struct vsi_iommu *iommu; + list_for_each_entry(iommu, &vsi_domain->iommus, node) { if (pm_runtime_get(iommu->dev) < 0) continue; -- 2.53.0