Re: [PATCH] iio: backend: fix uninitialized data in debugfs
Andy Shevchenko <[email protected]>
| Newsgroups | org.kernel.vger.kernel-janitors,org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel |
|---|---|
| Organization | Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo |
| Message-ID | <[email protected]> |
On Thu, Jun 04, 2026 at 01:42:11PM +0300, Dan Carpenter wrote: > On Thu, Jun 04, 2026 at 01:38:50PM +0300, Dan Carpenter wrote: > > 168 ret = sscanf(buf, "%i %i", &back->cached_reg_addr, &val); > > ^^^ > > Uninitialized variable. > > s/variable/data/. With what I asked in the previous reply and what you explained there (thanks, btw!) I still think your patches are not fully correct. They will require to atomically write all or nothing. If we want support partial writes we need to go with that differently (reset ppos when we got enough or more than enough data). -- With Best Regards, Andy Shevchenko