[PATCH] dmaengine: ti: k3-udma: Use common error handling code in udma_prep_slave_sg_pkt()
Markus Elfring <[email protected]> Wed, 10 Jun 2026 21:47:35 +0200
| Newsgroups | org.kernel.vger.kernel-janitors,org.kernel.vger.dmaengine,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
From: Markus Elfring <[email protected]> Date: Wed, 10 Jun 2026 21:43:12 +0200 Use an additional label so that a bit of exception handling can be better reused at the end of an if branch. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <[email protected]> --- drivers/dma/ti/k3-udma.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c index 1cf158eb7bdb..1ee779d73921 100644 --- a/drivers/dma/ti/k3-udma.c +++ b/drivers/dma/ti/k3-udma.c @@ -3270,10 +3270,7 @@ udma_prep_slave_sg_pkt(struct udma_chan *uc, struct scatterlist *sgl, if (!hwdesc->cppi5_desc_vaddr) { dev_err(uc->ud->dev, "descriptor%d allocation failed\n", i); - - udma_free_hwdesc(uc, d); - kfree(d); - return NULL; + goto free_hwdesc; } d->residue += sg_len; @@ -3309,6 +3306,7 @@ udma_prep_slave_sg_pkt(struct udma_chan *uc, struct scatterlist *sgl, dev_err(uc->ud->dev, "%s: Transfer size %u is over the supported 4M range\n", __func__, d->residue); +free_hwdesc: udma_free_hwdesc(uc, d); kfree(d); return NULL; -- 2.54.0