Re: [PATCH] mm/vmalloc: Use more common error handling code in pcpu_get_vm_areas()

On Tue, Jun 16, 2026 at 06:14:52PM +0200, Markus Elfring wrote:
> From: Markus Elfring <[email protected]>
> Date: Tue, 16 Jun 2026 18:00:16 +0200
> 
> Use an existing label once more so that a bit of exception handling can be
> better reused at the end of this function implementation.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <[email protected]>
> ---
>  mm/vmalloc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 1afca3568b9b..21a890586fef 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -5198,9 +5198,7 @@ struct vm_struct **pcpu_get_vm_areas(const unsigned long *offsets,
>  		kfree(vms[area]);
>  	}
>  	spin_unlock(&free_vmap_area_lock);
> -	kfree(vas);
> -	kfree(vms);
> -	return NULL;
> +	goto err_free2;
>  }
>  
>  /**
> -- 
> 2.54.0
> 
More removing then adding!

Reviewed-by: Uladzislau Rezki (Sony) <[email protected]>

--
Uladzislau Rezki