[PATCH] crypto: hisilicon - Use more common code in sec_alg_skcipher_crypto()
Markus Elfring <[email protected]> Wed, 17 Jun 2026 08:03:11 +0200
| Newsgroups | org.kernel.vger.kernel-janitors,org.kernel.vger.linux-crypto,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
From: Markus Elfring <[email protected]> Date: Wed, 17 Jun 2026 07:51:26 +0200 Move a label so that a bit of common code can be better reused at the end of this function implementation. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <[email protected]> --- drivers/crypto/hisilicon/sec/sec_algs.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/hisilicon/sec/sec_algs.c b/drivers/crypto/hisilicon/sec/sec_algs.c index 85eecbb40e7e..024fe1001875 100644 --- a/drivers/crypto/hisilicon/sec/sec_algs.c +++ b/drivers/crypto/hisilicon/sec/sec_algs.c @@ -833,6 +833,7 @@ static int sec_alg_skcipher_crypto(struct skcipher_request *skreq, kfree(splits_in); kfree(splits_out_nents); kfree(splits_out); +err_free_split_sizes: kfree(split_sizes); return ret; @@ -853,10 +854,7 @@ static int sec_alg_skcipher_crypto(struct skcipher_request *skreq, err_unmap_in_sg: sec_unmap_sg_on_err(skreq->src, steps, splits_in, splits_in_nents, sec_req->len_in, info->dev); -err_free_split_sizes: - kfree(split_sizes); - - return ret; + goto err_free_split_sizes; } static int sec_alg_skcipher_encrypt(struct skcipher_request *req) -- 2.54.0