Re: [PATCH] block: partitions: Use seq_buf_putc() in cmdline_partition()

Andy Shevchenko <[email protected]> Thu, 25 Jun 2026 11:18:12 +0300

Newsgroups	org.kernel.vger.kernel-janitors,org.kernel.vger.linux-block,org.kernel.vger.linux-kernel
Organization	Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo
Message-ID	<[email protected]>

On Thu, Jun 25, 2026 at 10:08:01AM +0200, Markus Elfring wrote:
> 
> A single line break should be put into a sequence buffer.
> Thus use the corresponding function “seq_buf_putc”.

“seq_buf_putc()”.

> The source code was transformed by using the Coccinelle software.

...

>  	cmdline_parts_set(parts, disk_size, state);
>  	cmdline_parts_verifier(1, state);

> -
> -	seq_buf_puts(&state->pp_buf, "\n");
> -
> +	seq_buf_putc(&state->pp_buf, '\n');

Why did you remove blank lines?

>  	return 1;

-- 
With Best Regards,
Andy Shevchenko