Re: [PATCH] block: partitions: Use seq_buf_putc() in cmdline_partition()

Andy Shevchenko <[email protected]> Thu, 25 Jun 2026 17:27:34 +0300

Newsgroups	org.kernel.vger.kernel-janitors,org.kernel.vger.linux-block,org.kernel.vger.linux-kernel
Organization	Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo
Message-ID	<[email protected]>

On Thu, Jun 25, 2026 at 02:18:49PM +0200, Markus Elfring wrote:

...

> >>  	cmdline_parts_set(parts, disk_size, state);
> >>  	cmdline_parts_verifier(1, state);
> > 
> >> -
> >> -	seq_buf_puts(&state->pp_buf, "\n");
> >> -
> >> +	seq_buf_putc(&state->pp_buf, '\n');
> > 
> > Why did you remove blank lines?
> > 
> >>  	return 1;
> I imagine that this source code place can become a bit more succinct.
> 
> See also:
> efi_partition()
> https://elixir.bootlin.com/linux/v7.1.1/source/block/partitions/efi.c#L694-L756
> 
> Do you insist to preserve two blank lines here?

Yes.

-- 
With Best Regards,
Andy Shevchenko