Re: [PATCH] tracing: Cleanup event_enable_trigger_parse() by using __free()
Markus Elfring <[email protected]> Fri, 3 Jul 2026 07:00:10 +0200
| Newsgroups | org.kernel.vger.kernel-janitors,org.kernel.vger.linux-kernel,org.kernel.vger.linux-trace-kernel |
|---|---|
| Message-ID | <[email protected]> |
>> …
>>> +++ b/kernel/trace/trace_events_trigger.c
>>> @@ -1739,7 +1739,7 @@ int event_enable_trigger_parse(struct event_command *cmd_ops,
>>> char *glob, char *cmd, char *param_and_filter)
>>> {
>>> struct trace_event_file *event_enable_file;
>>> - struct enable_trigger_data *enable_data;
>>> + struct enable_trigger_data *enable_data __free(kfree) = NULL;
>> …
>>
>> How do you think about to reduce the scope for this local variable?
>>
>
> No, it's fine as is.
Does this feedback mean that you disagree to an essential development requirement
according to such a programming interface?
https://elixir.bootlin.com/linux/v7.1.2/source/include/linux/cleanup.h#L142-L153
Regards,
Markus