Re: [PATCH 1/2] staging: rtl8723bs: drop GEN_CMD_CODE macro and capitalize labels

Greg Kroah-Hartman <[email protected]> Tue, 7 Jul 2026 13:07:01 +0200

Newsgroups	org.kernel.vger.kernel-janitors,dev.linux.lists.linux-staging,org.kernel.vger.linux-kernel
Message-ID	<2026070750-myself-hardhat-295f@gregkh>

On Tue, Jun 09, 2026 at 09:42:55PM -0400, Aiman Najjar wrote:
> The use of GEN_CMD_CODE macro to generate cmd enum label names is applied
> inconsistently and is confusing, it also makes it harder to make use of
> tools such as clangd when looking up symbols.
> 
> Replace them with writing the enum labels directly and adopting
> new capitalized names instead of the current camel case ones.
> 
> Signed-off-by: Aiman Najjar <[email protected]>
> ---
>  drivers/staging/rtl8723bs/core/rtw_ap.c       |   4 +-
>  drivers/staging/rtl8723bs/core/rtw_cmd.c      | 190 +++++++++++++-------------
>  drivers/staging/rtl8723bs/core/rtw_mlme.c     |   4 +-
>  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c |  18 +--
>  drivers/staging/rtl8723bs/include/rtw_cmd.h   | 154 ++++++++++-----------
>  5 files changed, 181 insertions(+), 189 deletions(-)

Does not apply to the latest tree :(