Re: net: rnpgbe: Pass an expression directly in rnpgbe_rm_adapter()
Dan Carpenter <[email protected]> Thu, 16 Jul 2026 16:34:05 +0300
| Newsgroups | org.kernel.vger.kernel-janitors,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On Thu, Jul 16, 2026 at 03:24:22PM +0200, Andrew Lunn wrote: > On Thu, Jul 16, 2026 at 11:48:43AM +0200, Markus Elfring wrote: > > > In C writing if (!p) and if (p == NULL) are always equivalent but weirdly > > > the NULL doesn't have to zero. It's part of the C FAQ. > > > https://c-faq.com/null/machexamp.html It's just a bit of fun trivia that > > > doesn't really matter unless you have a time machine. Even if you invented > > > a time machine, the code here would still be fine because we have a NULL > > > test before dereferencing the results of our pointer math. > > Which expression evaluations would you interpret as pointer dereferences finally? > > https://c-faq.com/sx1/ > > This is all interesting, but nobody has yet explain how this function > can be called such that we have a NULL pointer. mucse cannot be NULL. We call pci_set_drvdata() during probe() and it is still valid when we call the remove() function. regards, dan carpenter