Re: fbdev: arkfb: Move a variable assignment behind a condition check in ics5342_init()
Markus Elfring <[email protected]> Sat, 18 Jul 2026 22:34:33 +0200
| Newsgroups | org.kernel.vger.kernel-janitors,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-fbdev,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
>> The address of a data structure member was determined before >> a corresponding null pointer check in the implementation of >> the function =E2=80=9Cics5342_init=E2=80=9D. >> >> Thus avoid the risk for undefined behaviour by moving the assignment >> for the variable =E2=80=9Cinfo=E2=80=9D behind a condition check. >> >> This issue was detected by using the Coccinelle software. >=20 > There is no "risk" here. > It just adds an offset to a potential NULL value (which isn't then used = afterwards). Does your understanding of programming language details differ from the vi= ew of SEI CERT C Coding Standard (from the Carnegie Mellon University)? https://cmu-sei.github.io/secure-coding-standards/sei-cert-c-coding-standa= rd/rules/expressions-exp/exp34-c/ Regards, Markus