Re: [cocci] [PATCH 01/36] coccinelle: misc: add cond_return_no_effect.cocci
Markus Elfring <[email protected]> Fri, 24 Jul 2026 13:19:28 +0200
| Newsgroups | org.kernel.vger.kernel-janitors,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
=E2=80=A6
> +++ b/scripts/coccinelle/misc/cond_return_no_effect.cocci
> @@ -0,0 +1,121 @@
=E2=80=A6
> +@depends on patch@
> +local idexpression ret;
> +expression E;
> +binary operator cmp =3D {<, <=3D, >, >=3D, =3D=3D, !=3D};
> +constant C;
> +@@
> +- ret =3D E;
> +- if (\(ret \| !ret \| ret cmp C\))
> +- return ret;
> +- return ret;
> ++ return E;
> +
> +@depends on patch@
> +idexpression ret;
> +binary operator cmp =3D {<, <=3D, >, >=3D, =3D=3D, !=3D};
> +constant C;
> +@@
> +- if (\(ret \| !ret \| ret cmp C\))
> +- return ret;
> + return ret;
=E2=80=A6
How do you think about to combine such transformation rules
by using an SmPL disjunction?
Regards,
Markus