Re: [v2 1/2] soc: fsl: dpio: Use scope-based resource management in dpaa2_io_store_create()
Markus Elfring <[email protected]> Tue, 28 Jul 2026 08:55:38 +0200
| Newsgroups | org.kernel.vger.kernel-janitors,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel,org.ozlabs.lists.linuxppc-dev |
|---|---|
| Message-ID | <[email protected]> |
>> https://elixir.bootlin.com/linux/v7.2-rc4/source/include/linux/cleanup.= h#L142-L146 >=20 > The context for the recommendation linked by you is (also from > cleanup.h): >=20 > * "When multiple variables in the same scope have cleanup attributes, > * at exit from the scope their associated cleanup functions are run in > * reverse order of definition (last defined, first cleanup)." > * > * When the unwind order matters it requires that variables be defined > * mid-function scope rather than at the top of the file. Take the > * following example and notice the bug highlighted by "!!":: >=20 > Which is not the case of these simple functions which only need a kfree. How will development concerns evolve further also according to previous cl= arification attempts? Clarifying confusion of our variable placement rules caused by cleanup.h https://lore.kernel.org/ksummit/CAHk-=3DwhPZoi03ZwphxiW6cuWPtC3nyKYS8_BThg= [email protected]/ https://lkml.org/lkml/2025/11/18/1766 Regards, Markus