Re: [cocci] [v3] coccinelle: Detect clk_register() anti-pattern

Markus Elfring <[email protected]>
Newsgroups org.kernel.vger.kernel-janitors,org.kernel.vger.linux-clk,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
…
>> another issue is that in one case, removing the error message leaves:
>>
>> ret = PTR_ERR(inno->phyclk);
>> return ret;
>>
>> This could be cleaned up to just return PTR_ERR(inno->phyclk)
> Note that there are lots of occurrences of
> 
> ret = e;
> return ret;
> 
> for some expression ret and e, and 99.99% of them are fine as is.  But in
> this specific case of error handling code, perhaps it is not useful to
> introduce more of them.

Will such a development concern trigger further collateral evolution
for desirable source code transformation approaches?

Regards,
Markus
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.