Re: [PATCH v2] net: phy: spi_ks8995: add dependency on GPIO

David Miller <davem-fT/PcQaiUtIeIZ0/[email protected]> Tue, 16 Feb 2016 20:36:06 -0500 (EST)

Newsgroups	org.kernel.vger.kernel-testers,org.kernel.vger.linux-kernel,org.kernel.vger.netdev
Message-ID	<[email protected]>

From: Sudip Mukherjee <[email protected]>
Date: Sat, 13 Feb 2016 19:33:15 +0530

> The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing
> with the error:
>  drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value'
>  drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc'
> 
> GPIO is now used to reset the switch so we should have a dependency on
> GPIOLIB. While adding the dependency also add COMPILE_TEST so that we
> can build test it.
> 
> Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO")
> Cc: Helmut Buchsbaum <[email protected]>
> Signed-off-by: Sudip Mukherjee <sudip-ofJRbWXBVFamYgehrs7/[email protected]>
> ---
> 
> v2: added COMPILE_TEST and gpio/consumer.h

I'm going to apply Arnd's patch because it properly removes the
unnecessary linux/gpio.h include.

Thanks.