Re: [PATCH v3 3/8] module: Give 'enum pkey_id_type' a more specific name
=?utf-8?q?Thomas_Wei=C3=9Fschuh?= <[email protected]>
| Newsgroups | org.kernel.vger.keyrings,org.kernel.vger.bpf,org.kernel.vger.linux-integrity,org.kernel.vger.linux-kbuild,org.kernel.vger.linux-kernel,org.kernel.vger.linux-kselftest,org.kernel.vger.linux-modules,org.kernel.vger.linux-s390,org.kernel.vger.linux-security-module |
|---|---|
| Message-ID | <20260305125639-96c4c8e6-b758-4bd6-aa11-db76f6f8c3c3@linutronix.de> |
On Thu, Mar 05, 2026 at 10:52:47AM +0000, David Howells wrote: > > Thomas WeiÃschuh <[email protected]> wrote: > > > -enum pkey_id_type { > > - PKEY_ID_PKCS7 = 2, /* Signature in PKCS#7 message */ > > +enum module_signature_type { > > + MODULE_SIGNATURE_TYPE_PKCS7 = 2, /* Signature in PKCS#7 message */ > > }; > > It might be best to just kill the enum and replace it with a single #define. I am about to introduce another value in [0]. But personally I don't really care one way or another. [0] https://lore.kernel.org/lkml/[email protected]/