Re: [PATCH v1] treewide: Fix indentation and whitespace in Kconfig files

On Tue, Apr 07, 2026 at 09:58:56AM -0400, Liam R. Howlett wrote:
> * Anand Moon <[email protected]> [260407 01:40]:
> > Clean up inconsistent indentation (mixing tabs and spaces) and remove
> > extraneous whitespace in several Kconfig files across the tree.
> > This is a purely cosmetic change to improve readability.
> >
> > Adjust indentation from spaces to tab (+optional two spaces) as in
> > coding style with command like:
> >
> > $ sed -e 's/^        /\t/' -i */Kconfig
> >
> > Signed-off-by: Anand Moon <[email protected]>
>
> For the mm section,
>
> Reviewed-by: Liam R. Howlett <[email protected]>

Looks correct to me for mm also, so:

Reviewed-by: Lorenzo Stoakes <[email protected]>

Cheers, Lorenzo

>
> > ---
> >  certs/Kconfig | 16 ++++++++--------
> >  fs/Kconfig    |  6 +++---
> >  init/Kconfig  | 24 ++++++++++++------------
> >  lib/Kconfig   |  2 +-
> >  mm/Kconfig    |  4 ++--
> >  5 files changed, 26 insertions(+), 26 deletions(-)
> >
> > diff --git a/certs/Kconfig b/certs/Kconfig
> > index 8e39a80c7abe5..9d2bf7fb5b9e4 100644
> > --- a/certs/Kconfig
> > +++ b/certs/Kconfig
> > @@ -6,14 +6,14 @@ config MODULE_SIG_KEY
> >  	default "certs/signing_key.pem"
> >  	depends on MODULE_SIG || (IMA_APPRAISE_MODSIG && MODULES)
> >  	help
> > -         Provide the file name of a private key/certificate in PEM format,
> > -         or a PKCS#11 URI according to RFC7512. The file should contain, or
> > -         the URI should identify, both the certificate and its corresponding
> > -         private key.
> > -
> > -         If this option is unchanged from its default "certs/signing_key.pem",
> > -         then the kernel will automatically generate the private key and
> > -         certificate as described in Documentation/admin-guide/module-signing.rst
> > +	 Provide the file name of a private key/certificate in PEM format,
> > +	 or a PKCS#11 URI according to RFC7512. The file should contain, or
> > +	 the URI should identify, both the certificate and its corresponding
> > +	 private key.
> > +
> > +	 If this option is unchanged from its default "certs/signing_key.pem",
> > +	 then the kernel will automatically generate the private key and
> > +	 certificate as described in Documentation/admin-guide/module-signing.rst
> >
> >  choice
> >  	prompt "Type of module signing key to be generated"
> > diff --git a/fs/Kconfig b/fs/Kconfig
> > index 0bfdaecaa8775..74110311968aa 100644
> > --- a/fs/Kconfig
> > +++ b/fs/Kconfig
> > @@ -78,7 +78,7 @@ config FS_DAX
> >  	  --map=mem:
> >  	  https://docs.pmem.io/ndctl-user-guide/ndctl-man-pages/ndctl-create-namespace
> >
> > -          For ndctl to work CONFIG_DEV_DAX needs to be enabled as well. For most
> > +	  For ndctl to work CONFIG_DEV_DAX needs to be enabled as well. For most
> >  	  file systems DAX support needs to be manually enabled globally or
> >  	  per-inode using a mount option as well.  See the file documentation in
> >  	  Documentation/filesystems/dax.rst for details.
> > @@ -116,8 +116,8 @@ config FILE_LOCKING
> >  	default y
> >  	help
> >  	  This option enables standard file locking support, required
> > -          for filesystems like NFS and for the flock() system
> > -          call. Disabling this option saves about 11k.
> > +	  for filesystems like NFS and for the flock() system
> > +	  call. Disabling this option saves about 11k.
> >
> >  source "fs/crypto/Kconfig"
> >
> > diff --git a/init/Kconfig b/init/Kconfig
> > index 7484cd703bc1a..6fea1453c2941 100644
> > --- a/init/Kconfig
> > +++ b/init/Kconfig
> > @@ -1036,14 +1036,14 @@ config PAGE_COUNTER
> >  	bool
> >
> >  config CGROUP_FAVOR_DYNMODS
> > -        bool "Favor dynamic modification latency reduction by default"
> > -        help
> > -          This option enables the "favordynmods" mount option by default
> > -          which reduces the latencies of dynamic cgroup modifications such
> > -          as task migrations and controller on/offs at the cost of making
> > -          hot path operations such as forks and exits more expensive.
> > +	bool "Favor dynamic modification latency reduction by default"
> > +	help
> > +	  This option enables the "favordynmods" mount option by default
> > +	  which reduces the latencies of dynamic cgroup modifications such
> > +	  as task migrations and controller on/offs at the cost of making
> > +	  hot path operations such as forks and exits more expensive.
> >
> > -          Say N if unsure.
> > +	  Say N if unsure.
> >
> >  config MEMCG
> >  	bool "Memory controller"
> > @@ -1125,7 +1125,7 @@ config GROUP_SCHED_WEIGHT
> >  	def_bool n
> >
> >  config GROUP_SCHED_BANDWIDTH
> > -        def_bool n
> > +	def_bool n
> >
> >  config FAIR_GROUP_SCHED
> >  	bool "Group scheduling for SCHED_OTHER"
> > @@ -1625,10 +1625,10 @@ config LD_ORPHAN_WARN
> >  	depends on $(ld-option,--orphan-handling=error)
> >
> >  config LD_ORPHAN_WARN_LEVEL
> > -        string
> > -        depends on LD_ORPHAN_WARN
> > -        default "error" if WERROR
> > -        default "warn"
> > +	string
> > +	depends on LD_ORPHAN_WARN
> > +	default "error" if WERROR
> > +	default "warn"
> >
> >  config SYSCTL
> >  	bool
> > diff --git a/lib/Kconfig b/lib/Kconfig
> > index 0f2fb96106476..4b0026954a370 100644
> > --- a/lib/Kconfig
> > +++ b/lib/Kconfig
> > @@ -589,7 +589,7 @@ config OBJAGG
> >  config LWQ_TEST
> >  	bool "Boot-time test for lwq queuing"
> >  	help
> > -          Run boot-time test of light-weight queuing.
> > +	  Run boot-time test of light-weight queuing.
> >
> >  endmenu
> >
> > diff --git a/mm/Kconfig b/mm/Kconfig
> > index ebd8ea353687e..10a4ce4247fa1 100644
> > --- a/mm/Kconfig
> > +++ b/mm/Kconfig
> > @@ -1304,7 +1304,7 @@ config ARCH_HAS_PTE_SPECIAL
> >  	bool
> >
> >  config MAPPING_DIRTY_HELPERS
> > -        bool
> > +	bool
> >
> >  config KMAP_LOCAL
> >  	bool
> > @@ -1435,7 +1435,7 @@ config ARCH_HAS_USER_SHADOW_STACK
> >  	bool
> >  	help
> >  	  The architecture has hardware support for userspace shadow call
> > -          stacks (eg, x86 CET, arm64 GCS or RISC-V Zicfiss).
> > +	  stacks (eg, x86 CET, arm64 GCS or RISC-V Zicfiss).
> >
> >  config HAVE_ARCH_TLB_REMOVE_TABLE
> >  	def_bool n
> >
> > base-commit: bfe62a454542cfad3379f6ef5680b125f41e20f4
> > --
> > 2.50.1
> >