Re: [PATCH] crypto: fix OOB read in pefile_digest_pe_contents
Herbert Xu <[email protected]> Tue, 5 May 2026 13:46:43 +0800
| Newsgroups | org.kernel.vger.keyrings,org.kernel.vger.linux-crypto |
|---|---|
| Message-ID | <[email protected]> |
>
> diff --git a/crypto/asymmetric_keys/verify_pefile.c b/crypto/asymmetric_keys/verify_pefile.c
> index 1f3b227ba7f2..cec99db14129 100644
> --- a/crypto/asymmetric_keys/verify_pefile.c
> +++ b/crypto/asymmetric_keys/verify_pefile.c
> @@ -305,6 +305,8 @@ static int pefile_digest_pe_contents(const void *pebuf, unsigned int pelen,
>
> if (pelen > hashed_bytes) {
> tmp = hashed_bytes + ctx->certs_size;
> + if (tmp <= hashed_bytes || pelen < tmp)
> + return -ELIBBAD;
I know nothing about this but why should pelen == tmp fail?
Cheers,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt