Re: [PATCH] keys/trusted_keys: mark 'migratable' as __ro_after_init
Jarkko Sakkinen <[email protected]> Tue, 19 May 2026 11:15:56 +0300
| Newsgroups | org.kernel.vger.keyrings,org.kernel.vger.linux-integrity,org.kernel.vger.linux-kernel,org.kernel.vger.linux-security-module |
|---|---|
| Message-ID | <[email protected]> |
On Sat, May 16, 2026 at 03:22:47PM +0000, Len Bao wrote: > The 'migratable' variable is initialized only during the init phase > in the 'init_trusted' function and never changed. So, mark it as > __ro_after_init. > > Signed-off-by: Len Bao <[email protected]> > --- > security/keys/trusted-keys/trusted_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/keys/trusted-keys/trusted_core.c b/security/keys/trusted-keys/trusted_core.c > index 0b142d941..433579365 100644 > --- a/security/keys/trusted-keys/trusted_core.c > +++ b/security/keys/trusted-keys/trusted_core.c > @@ -59,7 +59,7 @@ DEFINE_STATIC_CALL_NULL(trusted_key_unseal, > DEFINE_STATIC_CALL_NULL(trusted_key_get_random, > *trusted_key_sources[0].ops->get_random); > static void (*trusted_key_exit)(void); > -static unsigned char migratable; > +static unsigned char migratable __ro_after_init; > > enum { > Opt_err, > -- > 2.43.0 > Thank you. Reviewed-by: Jarkko Sakkinen <[email protected]> BR, Jarkko