Re: [PATCH 2/3] KVM: Centralize slots_lock aquisition during KVM_CREATE_IRQCHIP
Avi Kivity <[email protected]> Thu, 16 Dec 2010 09:55:11 +0000
| Newsgroups | org.kernel.vger.kvm-ia64,org.kernel.vger.kvm |
|---|---|
| Message-ID | <[email protected]> |
On 12/16/2010 11:47 AM, Takuya Yoshikawa wrote: >> They're under srcu now, the comments are outdated. >> >> We used to have slots_lock be a rwsem, taken for read or write as >> necessary. Now we use srcu for read, and the slots_lock mutex + >> synchronize_srcu for write. >> > > > Ah, would you mind updating the comments? > - or just removing outdated ones? > > Fixing the comments would be good. > I will reread these locking based on your answer! > One day I'll write Documentation/kvm/locking.txt, so it could get outdated as well. -- error compiling committee.c: too many arguments to function