Re: [PATCH v12 1/6] KVM: Add architecture-defined TLB flush support

Cornelia Huck <[email protected]> Thu, 30 Oct 2014 12:06:58 +0000

Newsgroups	org.kernel.vger.kvm-ia64,org.infradead.lists.linux-arm-kernel,org.kernel.vger.kvm,org.kernel.vger.kvm-ppc
Message-ID	<[email protected]>

On Wed, 22 Oct 2014 15:34:06 -0700
Mario Smarduch <[email protected]> wrote:

> This patch adds support for architecture implemented VM TLB flush, currently
> ARMv7 defines HAVE_KVM_ARCH_TLB_FLUSH_ALL. This leaves other architectures 
> unaffected using the generic version. In subsequent patch ARMv7 defines
> HAVE_KVM_ARCH_TLB_FLUSH_ALL and it's own TLB flush interface.

Can you reword this a bit?

"Allow architectures to override the generic kvm_flush_remote_tlbs()
function via HAVE_KVM_ARCH_TLB_FLUSH_ALL. ARMv7 will need this to
provide its own TLB flush interface."

> 
> Signed-off-by: Mario Smarduch <[email protected]>
> ---
>  virt/kvm/Kconfig    |    3 +++
>  virt/kvm/kvm_main.c |    2 ++
>  2 files changed, 5 insertions(+)

Providing an override for the special cases looks sane to me.