Re: [PATCH 6/8]kvm/ia64: Make pmt table be able to hold physical mmio entries.

* On Monday 29 Sep 2008 10:56:58 Zhang, Xiantao wrote:
> From c459cae4b89b445a2b85be915b269676b6ff394f Mon Sep 17 00:00:00 2001
> From: Xiantao Zhang <[email protected]>
> Date: Sat, 27 Sep 2008 12:52:35 +0800
> Subject: [PATCH] kvm/ia64: Make pmt table be able to hold physical mmio
> entries.
>
> Don't try to do put_page once the entries are mmio.
> Set the tag to indicate the mmio space for vmm setting
> TLB's memory attribute.
> Signed-off-by: Xiantao Zhang <[email protected]>
> ---
>  arch/ia64/kvm/kvm-ia64.c |   20 +++++++++++++-------
>  1 files changed, 13 insertions(+), 7 deletions(-)
>
> diff --git a/arch/ia64/kvm/kvm-ia64.c b/arch/ia64/kvm/kvm-ia64.c
> index a6cf719..20622d6 100644
> --- a/arch/ia64/kvm/kvm-ia64.c
> +++ b/arch/ia64/kvm/kvm-ia64.c
> @@ -1437,17 +1437,23 @@ int kvm_arch_set_memory_region(struct kvm *kvm,
>  		int user_alloc)
>  {
>  	unsigned long i;
> -	struct page *page;
> +	unsigned long pfn;
>  	int npages = mem->memory_size >> PAGE_SHIFT;
>  	struct kvm_memory_slot *memslot = &kvm->memslots[mem->slot];
>  	unsigned long base_gfn = memslot->base_gfn;
> -
>  	for (i = 0; i < npages; i++) {

Please keep that line break; it'll be tougher to read without that.