Re: [patch] remove vcpu_info array v5
"Glauber Costa" <[email protected]>
| Newsgroups | org.kernel.vger.kvm-ia64,org.kernel.vger.kvm |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Nov 4, 2008 at 12:30 PM, Avi Kivity <[email protected]> wrote: > Glauber Costa wrote: >>> >>> This can't be the best way of determining the env pointer from a cpu >>> number. >>> >> >> By far it is not. But at least it does not depend on any kvm-specific >> data, and works >> for both qemu and kvm. So it's better to be this way. >> >> If we change this scheme to a better one, like a hash table, then >> it'll improve both qemu and kvm. >> >> > > There are simpler data structures. An example is an array. Since we have > an upper limit on the number of cpus (->max_cpus) there are no issues with > scaling (unlike with the algorithm above). Yes, but I believe the whole point of jes patches is to remove those limits. -- Glauber Costa. "Free as in Freedom" http://glommer.net "The less confident you are, the more serious you have to act."