Re: [PATCH] qemu: define and use VIRTIO_PFN_SHIFT

Anthony Liguori <[email protected]> Thu, 06 Nov 2008 20:02:10 +0000

Newsgroups	org.kernel.vger.kvm-ia64,org.kernel.vger.kvm,org.kernel.vger.kvm-ppc
Message-ID	<[email protected]>

Hollis Blanchard wrote:
> I wanted to make sure people on non-x86 architectures couldn't run into
> vring-size related problems that didn't also appear on x86.
>   

Having a VRING_SHIFT and a VRING_PAGE_SIZE where VRING_PAGE_SIZE != (1 
<< VRING_SHIFT) is almost certainly going to break things in unexpected 
ways because it's going against common understanding of the relationship 
between shift and page_size.

Regards,

Anthony Liguori