RE: [PATCH] KVM: Qemu: Fix ia64 build breakage.
"Zhang, Xiantao" <[email protected]>
| Newsgroups | org.kernel.vger.kvm-ia64,org.kernel.vger.kvm |
|---|---|
| Message-ID | <706158FABBBA044BAD4FE898A02E4BC2171F545E@pdsmsx503.ccr.corp.intel.com> |
Avi Kivity wrote: > Zhang, Xiantao wrote: >> From 96c99e79a83d4d8ed4dbd386a85a992e8affd724 Mon Sep 17 00:00:00 >> 2001 From: Xiantao Zhang <[email protected]> >> Date: Mon, 3 Nov 2008 12:26:16 +0800 >> Subject: [PATCH] KVM: Qemu: Fix ia64 build breakage. >> >> In io.h, it has some macros as fllowing: >> >> #define inb _inb >> #define inw _inw >> #define inl _inl >> #define outb _outb >> #define outw _outw >> #define outl _outl >> >> It conflicts with the fields of structure kvm_callback_ops. >> > > Wow, broken headers. > > Applied, thanks. We'll need a better solution though (like not using > these identifiers in kvm_callback_ops). Agree. If we found it again, I will make a patch like you suggested. Xiantao