Re: [PATCH] KVM: Userspace: Make device-assignment work for kvm/ia64.

Amit Shah <[email protected]> Mon, 10 Nov 2008 05:59:01 +0000

Newsgroups	org.kernel.vger.kvm-ia64,org.kernel.vger.kvm
Message-ID	<[email protected]>

* On Friday 07 Nov 2008 15:55:18 Zhang, Xiantao wrote:

> --- a/qemu/vl.c
> +++ b/qemu/vl.c
> @@ -8694,7 +8694,7 @@ static void help(int exitcode)
>  #endif
>  	   "-no-kvm-irqchip disable KVM kernel mode PIC/IOAPIC/LAPIC\n"
>  	   "-no-kvm-pit	    disable KVM kernel mode PIT\n"
> -#if defined(TARGET_I386) || defined(TARGET_X86_64) || defined(__linux__)
> +#if defined(TARGET_I386) || defined(TARGET_X86_64) || defined(TARGET_IA64)
> || defined(__linux__) "-pcidevice

It would be better to use #if defined (USE_KVM_DEVICE_ASSIGNMENT) here (and in 
the rest of the file) instead of adding architectures to this list as is done 
in the Makefile.

Amit