RE: [patch] fix kvm_arch_vcpu_ioctl_[gs]et_regs() - v2
"Zhang, Xiantao" <[email protected]>
| Newsgroups | org.kernel.vger.kvm-ia64 |
|---|---|
| Message-ID | <706158FABBBA044BAD4FE898A02E4BC21C78620C@pdsmsx503.ccr.corp.intel.com> |
Jes Sorensen wrote:
> Avi Kivity wrote:
>> This makes several tons of sense, but breaks backwards compatibility.
>> If I understand correctly, get/set was never used so this shouldn't
>> matter?
>>
>> I suggest reserving some space at the end of kvm_regs in case
>> further state needs to be added.
>>
>> Please add a KVM_CAP_ entry to advertise the fixup. This way
>> userspace can determine that it's compiling or running on an old
>> kernel and error out gracefully.
>
> Hi Avi,
>
> Here's an update version of this patch, which leaves some space for
> future extensions in struct kvm_regs. The KVM_CAP is unnecessary as
> GET/SET_REGS never worked on ia64.
Avi,
Please help to queue it for 2.6.28 merge. We will push changes in userland for live migration , and 2.6.29 should be ready for live migration.
Xiantao
Acked-by : Xiantao Zhang <[email protected]>