Re: [PATCH] kvm : qemu : fix compilation error in kvm-userspace for

On Thu, Mar 05, 2009 at 09:36:13AM +0800, Zhang, Yang wrote:
> Marcelo Tosatti wrote:
> > On Tue, Mar 03, 2009 at 11:38:17AM +0800, Zhang, Yang wrote:
> >> diff --git a/qemu/hw/i8259.c b/qemu/hw/i8259.c
> >> index 9cb3941..025f993 100644
> >> --- a/qemu/hw/i8259.c
> >> +++ b/qemu/hw/i8259.c
> >> @@ -189,8 +189,10 @@ static void i8259_set_irq(void *opaque, int
> >>          irq, int level)      if (kvm_enabled()) { int pic_ret;
> >>          if (kvm_set_irq(irq, level, &pic_ret)) {
> >> +#ifndef TARGET_IA64
> >>              if (pic_ret != 0)
> >>                  apic_set_irq_delivered();
> >> +#endif
> > 
> > Why don't you define apic_set_irq_delivered for IA64?
> 
> seems right, But i cannot find the proper place to define it. 
> And i think we can do this at the time of we need to use it.

The thinking is avoid code from piling in kvm-userspace when it belongs
in upstream QEMU. #ifdef's like that are ugly, but OK. Will apply.

Can you please submit this one to be included in QEMU upstream?

commit f759e44e04f03798d83de53d2c295965c68126a2
Author: Yang <[email protected]>
Date:   Thu Jan 15 13:03:53 2009 +0800

    kvm: qemu: Save ia64 nvram

Thanks