Re: [PATCH] KVM: Qemu: Flush i-cache after ide-dma operation in IA64

Zhang, Xiantao wrote:
>> This is the wrong place to put this.  Once we stop bouncing
>> scatter/gather DMA, we will no longer call this function.
>>     
>
> This patch intends to fix the issue before adopting scatter/gather DMA mode. But if we want to keep this funtion, had better to pick it to avoid such issues in future. 
>
>   

This function is the wrong place, it just happens to be called.

>> The correct place is either in the device code itself, or in the dma
>> api (dma-helpers.c).
>>     
>
> Maybe dma-helpers.c 

Please send a patch with this in dma-helpers.c.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.