RE: [PATCH 02/04] qemu-kvm: Add header files for ia64.
"Zhang, Xiantao" <[email protected]>
| Newsgroups | org.kernel.vger.kvm-ia64,org.kernel.vger.kvm |
|---|---|
| Message-ID | <706158FABBBA044BAD4FE898A02E4BC236A2C0D2@pdsmsx503.ccr.corp.intel.com> |
Jes Sorensen wrote: > Zhang, Xiantao wrote: >> Hi, Jes >> There should be no issue here. You may refer to >> qemu-kvm/kvm/kernel/arch/x86/include/asm/kvm.h, and it also includes >> this stuff. I remebered this stuff was used to solve the issues >> when uses kernel header files in userspace and the author should be >> Avi:-) You know, kernel header may include CONFIG_$ARCH macros but >> they are meaningless in userspace, so needs a way to solve the gap. >> But anyway we can do some cleanup or introduce new ways to solve the >> issue. Xiantao > > Hi Xiantao, > > I noticed it's in the x86 code as well - but I still think it's silly > to add to the ia64 tree when we don't need it. > > Of course, Avi should fix up his headers too :-) You may see this stuff in every source file and header file in kvm's release tarball. :-) If the header file is not shared with external module, we can do some cleanup for them. Xiantao